add argFileAllowed to @CmdLine and implement the arg file content reading logic

Review Request #1643 — Created Jan. 22, 2015 and submitted — Latest diff uploaded

jinfeng
commons
jin/add_argfile
pants-reviews
areitz, ity, jsirois, zundel

Related to https://github.com/pantsbuild/pants/issues/972

  • add argFileAllowed to @CmdLine and implement the arg file content reading logic
  • update jar-tool to support argFileAllowed for -classpath, -files, -jars arguments.
  • add unit test for OptionInfo

CRs from Farner, Levenson are pending.

  1. Built jar-tool, args, args-core locally and use them to create a jar with @argfile specified in the cmdline.

  2. locally passed: ./pants test tests/java/com/twitter/common/args:medium

  3. Travis CI passed: https://travis-ci.org/twitter/commons/builds/50248351

Loading...