Revert change to ivy.mustache template from https://rbcommons.com/s/twitter/r/1613/

Review Request #1639 - Created Jan. 22, 2015 and submitted

Information
Eric Ayers
pants
zundel/remove-conf-change-to-ivy-template
974
8df0744...
Reviewers
pants-reviews
jsirois, patricklaw
Revert change to ivy.mustache template from https://rbcommons.com/s/twitter/r/1613/

Manually, I noticed that setting 'url=' on a jar() config in BUILD.tools wasn't working properly. By manually working with the BUILD file, I was able to get it working again. John had already pointed out this line as suspect in a previous review:

https://rbcommons.com/s/twitter/r/716/diff/7/?file=1338157#file1338157line64

I re-ran ./pants idea and confirmed that pulling in sources is still working after this change:

$ rm -rf ~/.ivy2/pants
$ PANTS_DEV=1 ./pants clean-all
$ PANTS_DEV=1 ./pants idea examples/src/java/com/pants/examples/antlr4::
$ cat .pants.d/idea/idea/IdeaGen_idea/project/project.iml 

...
      <library name="external">
        <CLASSES>
          <root url="jar://$MODULE_DIR$/external-libs/antlr-runtime-3.5.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/ST4-4.0.7.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/antlr-2.7.7.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/org.abego.treelayout.core-1.0.1.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/antlr4-runtime-4.1.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/antlr4-4.1.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libs/stringtemplate-3.2.1.jar!/" />
        </CLASSES>
        <JAVADOC>
          <root url="jar://$MODULE_DIR$/external-libjavadoc/antlr4-runtime-4.1-javadoc.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libjavadoc/antlr4-4.1-javadoc.jar!/" />
        </JAVADOC>
        <SOURCES>
          <root url="jar://$MODULE_DIR$/external-libsources/antlr4-runtime-4.1-sources.jar!/" />
          <root url="jar://$MODULE_DIR$/external-libsources/antlr4-4.1-sources.jar!/" />
        </SOURCES>
      </library>
Patrick Lawson
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review Patrick. Submitted @ 8697e1a

John Sirois

A belated thank you for this one.

Loading...