Got ivy to map in javadoc and source jars for pants goal idea.

Review Request #1613 - Created Jan. 16, 2015 and submitted

Information
Eric Ayers
pants
zundel/idea-now-with-javadocs
941
1623
8ef5a63...
Reviewers
pants-reviews
ity, patricklaw

This involved a fair amount of finagling with conf variables spread across ivy_* and ide files,
and some changes to the ivy mustache. The mechanism by which confs are currently passed around
does not seem very robust. The whole system would probably benefit from some refactoring to
abstract away ivy's inner workings and streamline generic mapping settings; it would be nice to
have an abstract interface for mapping jar files. This could also make it easier to deal with
failing downloads, parallelization, or using a different jar mapping tool, but all that can
wait for an entirely different review.

Also cleaned up some style issues that got missed in the last patch for the idea goal.

Don't do extra work if no one wants sources.

(Previously the patch was posted for review here https://rbcommons.com/s/twitter/r/716/)

Integration test added.
CI is passing, see BUG link.

Issues

  • 0
  • 10
  • 3
  • 13
Description From Last Updated
Eric Ayers
Eric Ayers
Eric Ayers
Nick Howard (Twitter)
Eric Ayers
Eric Ayers
Patrick Lawson
Eric Ayers
Patrick Lawson
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews! Submitted at 53654fe

Loading...