Bugfixes in calling super methods in traversable_specs and traversable_dependency_specs

Review Request #1611 - Created Jan. 15, 2015 and submitted

Information
Eric Ayers
pants
zundel/jvm-target-traversable-dependency-specs
938
b903958...
Reviewers
pants-reviews
patricklaw
These look like just oversights that didn't cause problems because their superclass was
target that in both cases returned an empty list.

CI run (see bug link)

Patrick Lawson
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

commit 19f5f19

Nick Howard (Twitter)

Could you make regression tests for the traversable_dependency_specs related changes? Target doesn't always return [] for that case, so this is changing behavior--for the better--but it'd be good to ensure that behavior is spec'd out with tests so that it isn't changed unintentionally in the future.

  1. ok. See https://rbcommons.com/s/twitter/r/1637/

  2. thanks!

Loading...