Changed Scala version from 2.9.3 to 2.10.3 because zinc was using 2.10.3 already.

Review Request #1610 — Created Jan. 14, 2015 and submitted

fkorotkov
pants
66a802c...
pants-reviews
benjyw, ity, jsirois, stuhood, tejal, zundel
  • changed versions of corresponding libraries.

https://travis-ci.org/pantsbuild/pants/builds/47070392

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
FK
FK
ZU
  1. This all looks fine to me, but we aren't a scala shop so I'll leave it to someone else to press 'ship it!' Seems a shame that we have to copy the version number around to fix hard-coded strings so many places.

  2. 
      
TE
  1. Ship It!
  2. 
      
ST
  1. 
      
  2. BUILD.tools (Diff revision 1)
     
     

    The latest published version in the 2.10.x series is 2.10.4

  3. BUILD.tools (Diff revision 1)
     
     

    Internally we do not use the scala version in the target name (only in the artifact name.) It cuts down on the number of targets affected by upgrades.

  4. 
      
IT
  1. few nits.

  2. BUILD.tools (Diff revision 1)
     
     

    is there a reason why the name should be changed? isnt the rev enough? it would save this string replace throughout.

    and could we set a var for rev and use it everywhere so that next time you just have to change it in one place? same as we do for FINAGLE_REV below.

  3. 
      
FK
FK
FK
FK
FK
Review request changed

Status: Closed (submitted)

Loading...