raise TaskError on python antlr generation failure

Review Request #1604 — Created Jan. 13, 2015 and submitted

dturner-tw
pants
0a020ae...
pants-reviews
benjyw, jsirois, stuhood

Die immediately on python antlr generation failure, rather than just hoping a later step fails.

Ran new test (also manual testing).

  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
JS
  1. 
      
  2. This should just use the standard Task error channel and re-raise, ie:

    raise TaskError('ANTLR generation failed! {0}'.format(e))
    
  3. testprojects/src/python/antlr/BUILD (Diff revision 1)
     
     

    An update to testprojects/src/antlr/pants/backend/python/test/BUILD is missing in this diff.

  4. 
      
DT
JS
  1. 
      
  2. tests/python/pants_test/python/BUILD (Diff revision 2)
     
     

    This file does not exist on master or in this RB: https://github.com/pantsbuild/pants/tree/master/tests/python/pants_test/python/

  3. 
      
DT
JS
  1. Ship It!
  2. 
      
IT
  1. Ship It!
  2. 
      
NH
  1. lgtm other than the test name.

  2. how about test_invalid_antlr_grammar_fails

    1. Ack, too late, already pushed. Sorry! But I've got another RB on this anyway, so I'll do it there.

  3. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...