Fix a test broken by 9e911242ffb416912f918a8026f15cfdae31da09.

Review Request #1591 — Created Jan. 10, 2015 and submitted

benjyw
pants
b3fb9e8...
pants-reviews
zundel
Pushed TBR to fix the build.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/46526897

ZU
  1. 
      
  2. Drat, this is still failing apparently:

               ______ TestZincUtils.test_get_compile_args _______
    
                         self = <test_zinc_utils.TestZincUtils testMethod=test_get_compile_args>
    
                             def test_get_compile_args(self):
                               classpath = [os.path.join(self.build_root, 'foo.jar'),
                                            '/outside-build-root/bar.jar']
                               sources = ['X.scala']
    
                               args = ZincUtils._get_compile_args([], classpath, sources, 'bogus output dir',
                                                                   'bogus analysis file', [])
                               classpath_found = False
                               classpath_correct = False
                               for arg in args:
                                 if classpath_found:
                                   # Classpath elements are always relative to the build root.
                         >         self.assertEquals('foo.jar:../../../../../../../outside-build-root/bar.jar', arg)
                         E         AssertionError: u'foo.jar:../../../../../../../outside-build-root/bar.jar' != u'foo.jar:../../outside-build-root/bar.jar'
                         E         - foo.jar:../../../../../../../outside-build-root/bar.jar
                         E         ?         ---------------
                         E         + foo.jar:../../outside-build-root/bar.jar
    
    1. Yuck, that passed locally on my laptop. I guess this makes sense - the buildroot is at a different depth on different systems.

    2. It makes sense, but tests really shouldn't be sensitive to the environment that they're run in.

  3. 
      
BE
BE
ZU
  1. I think this RB needs to be marked as submitted/discarded. Another fix went in at cf2d88dcbc366e8eaaff90ac4e35356cf7eae75f instead.

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 4fd2585979b68761480f0c338eaa9207f1a1ed15.

Loading...