Don't realpath jars on the classpath.

Review Request #1588 — Created Jan. 9, 2015 and submitted

benjyw
pants
c5f4698...
pants-reviews
dturner-tw, patricklaw
We use a symlink farm so that paths inside zinc analysis files will be portable.

The realpath-ing caused zinc analysis to contain direct references into the
ivy cache, which is obviously not portable.

CI baking: https://travis-ci.org/pantsbuild/pants/builds/46501760

TODO: Add a regression test. Putting this out there now to unblock folks.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
BE
PA
  1. Ship It!
  2. 
      
PA
  1. 
      
  2. src/python/pants/util/dirutil.py (Diff revision 1)
     
     

    Belated post ship issue: this can also cause inconsistency across artifacts. We should probably just pick one somehow.

    1. Good point! Will always pick the relpath, since that's the known case.

  3. 
      
BE
DT
  1. 
      
  2. src/python/pants/util/dirutil.py (Diff revision 2)
     
     

    nit: s/Aurora/Mesos/

  3. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 9e911242ffb416912f918a8026f15cfdae31da09.

Loading...