Respect dep order in the breadth 1st dep walk.

Review Request #156 — Created March 27, 2014 and submitted

jsirois
commons
jsirois/pants/cp_breadth_first
272
pants-reviews
benjyw, ity
commit 463f01708964db76ad60e4367316367f439d4fdf
Author: John Sirois <jsirois@twitter.com>
Date:   Thu Mar 27 09:52:59 2014 -0600

    Respect dep order in the breadth 1st dep walk.
    
    This change led to a zinc error claiming jline was incompatible.
    Notably, the custom jline dep in BUILD.tools was now 1st on the
    classpath.  It turns out zinc / scala-compiler pulls in a jline
    on its own so kill the un-needed jline dep.

 BUILD.tools                                 | 1 -
 src/python/twitter/pants/tasks/ivy_utils.py | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
$ ./build-support/bin/ci.sh -sp

Also confirmed this "fixed" many internal builds that are very broken and rely on luck of the draw (really maven's hidden rules) to get the right stuff on the classpath 1st.
IT
  1. Looks good!
  2. 
      
BE
  1. Ship It!
  2. 
      
JS
  1. Thanks folks - merged
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...