Remove dead code and no longer needed topo sort from cache_manager
Review Request #1553 - Created Dec. 31, 2014 and submitted
|benjyw, jsirois, patricklaw, zundel|
Target.transitive_invalidation_hash appears to recursively call transitive_invalidation_hash on dependencies
and memoize results, so order in which we create VersionedTargets should no longer matter.
The dictionary id_to_hash likely cared about this order, judging by the comment above it, but that is dead code now -- it's only written, never read.
This looks fine to me. I synced back a year and read this code, and I agree that this change should have no consequences. We used to manage transitive invalidation here - the fprints of your deps were read from id_to_hash and mixed in to your own fprint, which is why the targets had to be processed in topological order (although it could also have just used memoization). However now this is all done in the fprint strategy, and this sort is indeed unneeded.
Revision 2 (+10 -39)
Status: Closed (submitted)