Migrate jvm_compile's direct config accesses to the options system.

Review Request #1552 — Created Dec. 31, 2014 and submitted

benjyw
pants
816bbc9...
pants-reviews
ity, patricklaw, zundel

Note that a couple of inherited config accesses (from Task and NailgunTask)
are still there, but their config section has been changed from java-compile
to compile.java (and similarly for scala). Thus the java-compile section
is now completely gone.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/45511256

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
ZU
  1. 
      
  2. pants.ini (Diff revision 1)
     
     

    Shouldn't this also be migrated to jvm_options? Looks like you changed the code and added it to migrate_config.py.

    1. Good catch. I moved it to the new section before renaming it, so the migration script didn't see it.

  3. 
      
IT
  1. Ship It!

  2. 
      
PA
  1. Ship It!
  2. 
      
NH
  1. 
      
  2. Should the type here be append to match JvmTask's --jvm-options semantics?

    1. I'm not sure, but I think not on balance. The dilemma is that with type='append' you can never remove anything from the list. E.g., anything you specify on the cmd-line is appended to whatever is in pants.ini. I'm unsure if that's the right behavior or not, but I suspect it isn't.

      However I do agree that this should be consistent, and I will change it in JvmTask to match this.

    2. That does mean that anyone trying to use --jvm-options from the commandline will have to change the syntax they use as the list type is an evaled python expression instead of a string.

  3. should the underscores here be dashes?

  4. 
      
BE
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as ab684469a7527b71a608c2dfbba0c35d85e4ff9a.

Loading...