Upgrade twitter/commons to pants 0.0.27.

Review Request #1513 — Created Dec. 18, 2014 and submitted

jsirois
commons
jsirois/pants/upgrade-0.0.26
339
1518
6b31419...
pants-reviews
ity, stuhood, wickman, Yasumoto

Fixup BUILDs, plugins and scripts to work with pants API changes.

Run the migrate_config tool from pants to convert many pants.ini sections
and keys. Also kill some un-needed keys.

Prepare a twitter.common.pants 0.7.0 release.

Upgrade BUILD.tools and fix code to conform to more stringent checkstyle
and jmake expectations that result.

Also upgrade to virtualenv 1.11.6 and allow custom PIP_OPTIONS to
be specified (useful for bootstrapping pants as eggs in the venv for
easy IDEA project setup to hack on pants-plugins).

BUILD.tools | 6 +--
build-support/bin/ci.sh | 13 ++++--
build-support/commons/ivy/BUILD | 22 ---------
build-support/virtualenv | 2 +-
pants | 3 +-
pants-plugins/3rdparty/BUILD | 2 +-
pants-plugins/src/python/twitter/common/pants/BUILD | 2 +-
pants-plugins/src/python/twitter/common/pants/jvm/args/tasks/resource_mapper.py | 2 +-
pants-plugins/src/python/twitter/common/pants/jvm/extras/register.py | 4 --
pants-plugins/src/python/twitter/common/pants/python/commons/BUILD | 17 ++++++-
pants-plugins/src/python/twitter/common/pants/python/commons/register.py | 20 +++++++-
src/thrift/com/twitter/service/BUILD => pants-plugins/src/python/twitter/common/pants/python/commons/remote_python_thrift_fileset.py | 57 ++++++++++++++---------
pants.ini | 126 +++++++++-----------------------------------------
src/java/com/twitter/common/application/BUILD | 4 +-
src/java/com/twitter/common/application/http/BUILD | 2 +-
src/java/com/twitter/common/application/modules/BUILD | 14 +++---
src/java/com/twitter/common/args/BUILD | 8 ++--
src/java/com/twitter/common/base/BUILD | 2 +-
src/java/com/twitter/common/checkstyle/BUILD | 2 +-
src/java/com/twitter/common/collections/BUILD | 2 +-
src/java/com/twitter/common/examples/hello/main/HelloMain.java | 2 +-
src/java/com/twitter/common/inject/BUILD | 4 +-
src/java/com/twitter/common/io/BUILD | 10 ++--
src/java/com/twitter/common/jar/tool/BUILD | 2 +-
src/java/com/twitter/common/junit/annotations/BUILD | 2 +-
src/java/com/twitter/common/junit/runner/BUILD | 2 +-
src/java/com/twitter/common/junit/runner/withretry/BUILD | 2 +-
src/java/com/twitter/common/logging/BUILD | 4 +-
src/java/com/twitter/common/logging/julbridge/BUILD | 2 +-
src/java/com/twitter/common/logging/log4j/BUILD | 2 +-
src/java/com/twitter/common/logging/scribe/BUILD | 2 +-
src/java/com/twitter/common/memcached/BUILD | 2 +-
src/java/com/twitter/common/metrics/BUILD | 2 +-
src/java/com/twitter/common/net/BUILD | 6 +--
src/java/com/twitter/common/net/http/BUILD | 2 +-
src/java/com/twitter/common/net/http/filters/BUILD | 2 +-
src/java/com/twitter/common/net/http/handlers/BUILD | 12 ++---
src/java/com/twitter/common/net/http/handlers/pprof/BUILD | 2 +-
src/java/com/twitter/common/objectsize/BUILD | 2 +-
src/java/com/twitter/common/quantity/BUILD | 2 +-
src/java/com/twitter/common/runtime/BUILD | 2 +-
src/java/com/twitter/common/security/unittest/BUILD | 2 +-
src/java/com/twitter/common/stats/BUILD | 14 +++---
src/java/com/twitter/common/testing/easymock/BUILD | 2 +-
src/java/com/twitter/common/testing/mockito/BUILD | 2 +-
src/java/com/twitter/common/text/BUILD | 2 +-
src/java/com/twitter/common/thrift/BUILD | 2 +-
src/java/com/twitter/common/tools/BUILD | 2 +-
src/java/com/twitter/common/util/BUILD | 12 ++---
src/java/com/twitter/common/util/caching/BUILD | 2 +-
src/java/com/twitter/common/util/templating/BUILD | 2 +-
src/java/com/twitter/common/webassets/bootstrap/BUILD | 2 +-
src/java/com/twitter/common/webassets/jquery/BUILD | 2 +-
src/java/com/twitter/common/zookeeper/BUILD | 4 +-
src/java/com/twitter/common/zookeeper/guice/BUILD | 2 +-
src/java/com/twitter/common/zookeeper/guice/client/BUILD | 2 +-
src/java/com/twitter/common/zookeeper/guice/client/flagged/BUILD | 2 +-
src/python/twitter/common/zookeeper/test_server.py | 2 +-
src/scala/com/twitter/common/stats/BUILD | 2 +-
src/scala/com/twitter/common/testing/BUILD | 2 +-
src/scala/com/twitter/common/tools/compiler/BUILD | 2 +-
src/thrift/com/twitter/service/BUILD | 87 ++++++++++------------------------
src/thrift/com/twitter/thrift/BUILD | 2 +-
src/thrift/org/apache/scribe/BUILD | 2 +-
tests/java/com/twitter/common/metrics/demo/MetricsPrecisionDemo.java | 15 +++---
tests/java/com/twitter/common/testing/BUILD | 12 ++---
tests/java/com/twitter/common/testing/{ => easymock}/EasyMockTestTest.java | 0
67 files changed, 230 insertions(+), 330 deletions(-)

Local CI ran green via ./build-support/bin/ci.sh.

Travis went green here: https://travis-ci.org/twitter/commons/builds/45985857

JS
JS
JS
JS
  1. Note - this is not as bad as it looks, all the src/{java,scala}/**/BUILD changes are just s|repo='build-support/commons/ivy:public'|repo=public|.

  2. 
      
JS
JS
IT
  1. lgtm - thanks for doing this!

  2. 
      
JS
JS
JS
JS
JS
  1. OK - PTAL. In particular I'm looking for feedback on https://rbcommons.com/s/twitter/r/1513/diff/#7
    Should the release be 0.7.0 or 0.6.0?

  2. 
      
JS
JS
JS
JS
JS
ST
  1. Ship It!
  2. 
      
IT
  1. Ship It!
  2. 
      
JS
  1. Thanks all - submitted at https://github.com/twitter/commons/commit/2a6aced7ce94dd5d269ac026405837ace1c87970
    The twitter.common.pants plugin is also published at 0.7.0: https://pypi.python.org/pypi/twitter.common.pants/0.7.0

  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...