Guard against long ids.

Review Request #150 — Created March 26, 2014 and submitted

jsirois
commons
jsirois/pants/safe_filename
270
pants-reviews
benjyw, patricklaw
commit 972a1eb4786c2d64b53e8dea7989d22f6cf71e36
Author: John Sirois <jsirois@twitter.com>
Date:   Tue Mar 25 12:24:17 2014 -0600

    Guard against long ids.
    
    The BuildInvalidator uses ids that most often come from targets and
    these can be lengthy when the targets are synthetic.  If the id > ~250
    characters, this will produce a hash filename that's too long for most
    common filesystems.  Guard against this with safe_filename and shorten
    to a hash iff needed to avoid this.

 src/python/twitter/pants/base/BUILD                | 3 ++-
 src/python/twitter/pants/base/build_invalidator.py | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
None.  This was lost in the merge where >1 year old cache code changed significantly.
  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
duplicate dependency? TE tejal
Am I misreading the diff, or is dirutil listed twice? BE benjyw
TE
  1. 
      
  2. src/python/twitter/pants/base/BUILD (Diff revision 1)
     
     
    duplicate dependency?
  3. 
      
PA
  1. Ship It!
  2. 
      
BE
  1. 
      
  2. src/python/twitter/pants/base/BUILD (Diff revision 1)
     
     
    Am I misreading the diff, or is dirutil listed twice?
  3. 
      
JS
JS
  1. Sorry about the description/summary change - still tooling my workflow and that was not intended.
  2. 
      
JS
BE
  1. Ship It!
  2. 
      
JS
  1. Thanks - merged.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...