-
-
src/python/pants/commands/goal_runner.py (Diff revision 1) before cleanup() was only called after builds that were interrupted. I think the reason was that out-of-date or nailguns with memory leaks could be timing out or hogging memory on the machine, so cleaning up the nailguns was done to make the next invocation of pants more likely to succeed.
Get rid of the Command class completely.
Review Request #1465 — Created Dec. 10, 2014 and submitted
Information | |
---|---|
benjyw | |
pants | |
805ba3b... | |
Reviewers | |
pants-reviews | |
ity, jsirois, patricklaw, zundel |
GoalRunner now just extends object.
The functionality previously in Command is now in GoalRunner.
Most of the functionality in pants_exe.py is now in GoalRunner too.
RIP old pants...
All integration and unit tests pass.
Change Summary:
Always kill nailguns on ctrl-c.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+110 -350) |
-
-
src/python/pants/bin/BUILD (Diff revision 2) This dep should be moved into :pants_exe - pants_exe.py depends directly on the GoalRunner with an import. At that point this target is a 1-1 alias so it can be killed and instead :pants_exe inlined in the python_binarys below.
-
src/python/pants/commands/goal_runner.py (Diff revision 2) Can you expand on this? Afaict you can actually delete it - there are no local
.output
and neitherGoalRunner.output
in the existing codebase.
Change Summary:
Address code review comment.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+109 -350) |