handle UTF-8 in thrift files for python
Review Request #1459 - Created Dec. 10, 2014 and submitted
| Information | |
|---|---|
| David Turner | |
| pants | |
| 1fa53c9... | |
| Reviewers | |
| pants-reviews | |
| ity, jinfeng, jsirois, peiyu | |
handle UTF-8 in thrift files for python
Ran new tests (red/green/go)
Ship It!
-
tests/python/pants_test/python/test_thrift_builder.py (Diff revision 1) -
remove?
Review request changed
Change Summary:
Remove commented-out broken test; my new test covers some of the same area.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (-18) |
Odd diffness going on here. To see the whole change you have to view https://rbcommons.com/s/twitter/r/1459/diff/1/ then https://rbcommons.com/s/twitter/r/1459/diff/2/ - afaict there is no way to see the whole change at once in RB at the moment. Can you re-post a full diff?
Review request changed
Change Summary:
real new diff
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+38 -41) |
Review request changed
Change Summary:
wrong diff
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+13 -6) |
Review request changed
Change Summary:
And this is the change that removes the cruft
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+13 -24) |