handle UTF-8 in thrift files for python

Review Request #1459 — Created Dec. 10, 2014 and submitted

dturner-tw
pants
1fa53c9...
pants-reviews
ity, jinfeng, jsirois, peiyu

handle UTF-8 in thrift files for python

Ran new tests (red/green/go)

JI
  1. Ship It!

  2. 
      
IT
  1. 
      
    1. The whole commented out region? Sure, we can always get it back.

  2. 
      
DT
JS
  1. Odd diffness going on here. To see the whole change you have to view https://rbcommons.com/s/twitter/r/1459/diff/1/ then https://rbcommons.com/s/twitter/r/1459/diff/2/ - afaict there is no way to see the whole change at once in RB at the moment. Can you re-post a full diff?

    1. Oh, rbtools decided it didn't like me. lemme fix that.

  2. 
      
DT
DT
DT
DT
Review request changed

Status: Closed (submitted)

Loading...