Fish Trophy

benjyw got a fish trophy!

More intuitive env var names for global-scope options.

Review Request #1441 — Created Dec. 7, 2014 and submitted

benjyw
pants
b103917...
pants-reviews
ity, jsirois, patricklaw, zundel

Previously for global option --bar-baz you had to set PANTS_DEFAULT_BAR_BAZ.
Now we allow PANTS_BAR_BAZ, eliding the explicit global scope 'DEFAULT'.

If the option name itself already starts with 'pants-', e.g., --pants-workdir,
we also allow PANTS_WORKDIR, instead of PANTS_PANTS_WORKDIR or
PANTS_DEFAULT_PANTS_WORKDIR.

Using env vars to set option values isn't necessarily common, but this will make
it more conveninent and intuitive. Also, it will allow the PANTS_CONFIG_OVERRIDE
mechanism to be retconned into a --config-override option.

CI passes.

JS
  1. Ship It!

  2. 
      
IT
  1. lgtm!

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 217a051cee572bd255d166fa0a228b8f33f3ae4b.
Loading...