Divorce expand_files from CWD.

Review Request #142 — Created March 24, 2014 and discarded

jsirois
commons
jsirois/pants/fix_source_collection
268
pants-reviews
benjyw, patricklaw
commit 29b5d93d3aa64d486619fc8866c2a91be1190690
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Mar 24 12:32:30 2014 -0600

    Divorce expand_files from CWD.
    
    Switch from abspath to adjoining the build_root.
    This is both safe in prod and in tests that establish
    their own build root.

 src/python/twitter/pants/targets/with_sources.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
$ rm -f pants.pex && ./pants.bootstrap goal clean-all
$ ./pants.bootstrap goal test tests/java/com/twitter/common/:all
PA
  1. This entire file moves in my refactor, and this change is something that's already been accounted for.  I'd recommend not pushing this, though I do otherwise approve of what it does.
    1. Sounds good.  Discarding.
  2. 
      
JS
Review request changed

Status: Discarded

Loading...