Change certain core configs into registered options.

Review Request #1373 — Created Nov. 20, 2014 and submitted

benjyw
pants
6d1989b...
pants-reviews
jsirois, patricklaw, zundel

These are options like pants_workdir, whose values can be interpolated
into pants.ini to create values for other options. So we treat them
specially: We refer to them as "bootstrap options" and we determine their
values in an early pass before getting the values for all the other options.

This allows, e.g., overriding --pants-workdir on the cmd line, like any other
option, but still having %(pants_workdir)s interpolations in config files
work as expected.

CI passed.

ZU
  1. 
      
  2. It seems odd that this same function is in two places (also in bootstrap_options). I don't see this one refereced?

    1. Ooops, that was a copy-paste without the corresponding delete... Removed.

  3. test when set from environment as well?

    1. Added.

    2. the test change looks OK but the diff pulled in a bunch of unrelated stuff.

    3. Ah crap, let me take a look.

    4. OK, I had some rebasing hell, but AFAICT what I pushed is OK.

  4. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 4a9fe9d7db5a1ff19e6c6c338cfb57786acf4aa8.
Loading...