Fixing VarsJsonHandler and VarsHandlerTest for Java 7+ which changes hashmap iteration order

Review Request #1368 — Created Nov. 20, 2014 and submitted

zundel
commons
2df26a0...
pants-reviews
ity, tejal

Fixing VarsJsonHandler and VarsHandlerTest for Java 7+ which changes hashmap iteration order

Ran all java tests in commons with:

./pants goal test {src,tests}/java/com/twitter/common::
./pants goal test {src,tests}/scala/com/twitter/common::

under Java 7 and re-ran the java tests with Java 8

ZU
  1. I ran into this when testing twitter-commons without the 'test-parallel-paths' option.

    1. er, that's testing without section 'jvm' parameter 'parallel_test_paths' in pants.ini

  2. 
      
IT
  1. thanks!

    1. Note this is in twitter commons, I can't commit it myself.

    2. yep, commited https://github.com/twitter/commons/commit/0e803d54b7090cadce4565400e6d06fd4ce51050

  2. 
      
TE
  1. Ship It!

  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

commit 0e803d54b7090cadce4565400e6d06fd4ce51050
Loading...