Fix a bug related to adding sibling resource bases.

Review Request #1367 — Created Nov. 20, 2014 and submitted

benjyw
pants
3be6b13...
pants-reviews
ity, jsirois, patricklaw

This bug was introduced in 3f5df746, a year ago:

git diff 3f5df746^..3f5df746 -- src/python/twitter/pants/tasks/jvm_task.py

Which leads me to believe that this code isn't necessary. Reviewers, please
chime in on whether we still need this sibling resource directory functionality
for sources, tests or both.

For example, do any pants.ini files at Twitter currently mention parallel_src_paths/parallel_test_paths?

It would be great to finally remove this code.



PA
  1. Ship It!

  2. 
      
ZU
  1. 
      
  2. It seems like the comment in pants.ini is referencing the open source twitter repo:

    https://github.com/twitter/commons/blob/master/pants.ini

    I removed this line and ran:

    ./pants goal test {src,tests}/java/com/twitter/common::

    But I'm not sure if this is what the comment in pants.ini is talking about :

    ; TODO(John Sirois): Kill this when commons tests are converted to use explicit test target
    ; (default is False).
    

    Regardless, I think we should move this from the pants.ini distributed with pants. Could you make that change?

  3. 
      
IT
  1. we dont have either of them (parallel_{test|src}_paths in use in any of our internal repos. but as Eric pointed out it is in use in https://github.com/twitter/commons/blob/master/pants.ini#L272

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as dee871cde05294a66e2dcfcd471e1a349ac209d1.
Loading...