src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 1)

Note, there can be multiple aliases pointed at the same classname, as in src/python/pants/backend/jvm/register.py:

'java_tests': JavaTests,
'junit_tests': JavaTests,


I guess the last one wins?  Maybe you somehow want to prefer some aliases?  If this isn't important, just add a comment.

1. 

   Tejal Desai Nov. 20, 2014, 6:36 p.m.

   At twitter we usages for both junit_tests and java_tests. It is not important which one is returned.

tests/python/pants_test/tasks/test_depmap.py (Diff revision 1)

nit, use .format() for string formatting

tests/python/pants_test/tasks/test_depmap.py (Diff revision 1)

nit: use .format() for string formatting.

src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 1)

use .format

1. 

   Tejal Desai Nov. 20, 2014, 7:58 p.m.

   I was under the notion .format is an overkill when you just one value to be substitued. I was confused when to use .format vs %s. and have been following the above rule.
   
   I just realized its going to be standard in pyhton 3.x.

2. 

   Eric Ayers Nov. 20, 2014, 8:06 p.m.

   FWIW, you can shorten it a bit with the numerical syntax "{0}".format(foo)

src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 2)

Show all issues

why not return a list so you dont just return the last one? so this becomes _get_pants_target_aliases ? unless there is a use case I am not thinking of here.

1. 

   Tejal Desai Nov. 20, 2014, 7:58 p.m.

   Plugin as a consumer for depmap goal does not need to know all aliases to determine the target type.
   
   The alias:TargetType mapping is 1:1.
   On the consumer side have logic in place for all target aliases and we treat java_tests and junit_tests as 1.
   After being said that, why do we dont use TargetclassName instead?
   
   - answer to that question is in plugin, we have builtin a functionality like the TargetDefinitionHelper based on aliases. 
   
   - aliases are user exposed objects and hence we want to stick to aliases.

2. 

   Ity Kaul Nov. 20, 2014, 8:10 p.m.

   ah, makes sense as long as you need only one alias to determine the type this should suffice. thanks for the explanation!

Ship It!

Ship It!