-
-
src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 1) Note, there can be multiple aliases pointed at the same classname, as in src/python/pants/backend/jvm/register.py:
'java_tests': JavaTests, 'junit_tests': JavaTests,
I guess the last one wins? Maybe you somehow want to prefer some aliases? If this isn't important, just add a comment.
-
tests/python/pants_test/tasks/test_depmap.py (Diff revision 1) nit, use .format() for string formatting
-
tests/python/pants_test/tasks/test_depmap.py (Diff revision 1) nit: use .format() for string formatting.
Add Pants Target Type to depmap so that intellij plugin can use this to identify scala target VS java target
Review Request #1366 — Created Nov. 20, 2014 and submitted
Information | |
---|---|
tejal | |
pants | |
655 | |
e464b0d... | |
Reviewers | |
pants-reviews | |
benjyw, fkorotkov, ity, zundel |
Add Pants Target Type to depmap so that intellij plugin can use this to identify scala target VS java target
Manually ran
1. ./pants goal test tests/python/pants_test/tasks:depmap
2. ./pants goal test tests/python/pants_test/tasks:depmap_integrationCi here https://travis-ci.org/pantsbuild/pants/builds/41554780
ZU
TE
Change Summary:
Code review comments.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+48 -12) |
IT
-
-
-
src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 2) why not return a list so you dont just return the last one? so this becomes _get_pants_target_aliases ? unless there is a use case I am not thinking of here.
TE
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+49 -13) |