Fix nasty BuildGraph bug

Review Request #1337 - Created Nov. 14, 2014 and submitted

Information
Patrick Lawson
pants
02d82b4...
Reviewers
pants-reviews
benjyw, ity, jsirois, zundel

Fixes a nasty bug when injecting target closures in BuildGraph.

Just because a target has been injected doesn't mean that its closure (and therefore its dependency edges) have been injected. The current code misses the case where a target was injected (but not its closure) and then has its closure injected later.

Added a test that identifies the bug, which now passes (doesn't on master): tests/python/pants_test/graph test_inject_then_inject_closure.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/41270498

Nick Howard (Twitter)
Eric Ayers
Patrick Lawson
Ity Kaul
Patrick Lawson
Eric Ayers
Patrick Lawson
Nick Howard (Twitter)
Patrick Lawson
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks guys, upstream at bdeb6958135db3adcc19623a0bf7461363fbc73c
Loading...