Turn dependency dupes into errors
Review Request #1332 — Created Nov. 14, 2014 and submitted
|ity, jsirois, patricklaw, stuhood|
We see a bunch of dupes pop up in dependency lists in our internal repos. Often they go unnoticed by whoever should be fixing them. They also make each parsing of the build graph quite noisy for the rest of our users.
This branch turns those warnings into errors. That ought to ensure they're caught early by whoever added the duplicate dependency and they won't hit master.
tested against a dependency list with dupes
|nit: The short description should be a single line and one sentence. The rest of the descriptions (that could exceed ...||PA patricklaw|
FYI, this change breaks my repo and I'm not sure what the extent of the damage is yet. In the future, I would like to land changes like this behind a flag and/or with a deprecation message to give me a grace period to fix things up.