- Download Diff

Summary:

create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download

Review Request #1316 — Created Nov. 11, 2014 and submitted Nov. 11, 2014, 11:51 p.m.

Information
Owner:	jinfeng
Repository:	pants
Branch:
Bugs:
Depends On:
Commit:	8a16f51...
Reviewers
Groups:	pants-reviews
People:	areitz, ity, jsirois, zundel

Description


Create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
Refactor to have a common.sh containing the set_archflags and logging functionalities.
Make the virtual env script a bit more robust against curl/tar/activate errors

Testing Done

manually tested:
1) not specifying VIRTUALENV_PACKAGE_LOCATION,
2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.

Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
What do you think about factoring these out into a common script, to be shared by this one & the ...	AR areitz	Nov. 11, 2014, 5:39 p.m.
If you build ${VIRTUALENV_URL}=${VIRTUALENV_PACKAGE_LOCATION}/virtualenv-$VIRTUALENV_VERSION.tar.gz here, it will make the next 4 lines easier to read.	AR areitz	Nov. 11, 2014, 5:41 p.m.

Testing Done:

		manually tested:
		1) not specifying VIRTUALENV_PACKAGE_LOCATION,
		2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
		3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.
	+
	+	Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40612446

build-support/virtualenv (Diff revision 1)

Show all issues

What do you think about factoring these out into a common script, to be shared by this one & the one above?

build-support/virtualenv (Diff revision 1)

Show all issues

If you build ${VIRTUALENV_URL}=${VIRTUALENV_PACKAGE_LOCATION}/virtualenv-$VIRTUALENV_VERSION.tar.gz here, it will make the next 4 lines easier to read.

build-support/virtualenv (Diff revision 1)
```
1>&2 should be removed (its done inside log())
```
1. JI
  
  jinfeng Nov. 11, 2014, 5:49 p.m.
  fixed
build-support/virtualenv (Diff revision 1)
```
nit: go ahead and surround all variables expanded with { }
```
1. JI
  
  jinfeng Nov. 11, 2014, 5:49 p.m.
  fixed

Change Summary:

address RB comments and update new travis run link.

Testing Done:

		manually tested:
		1) not specifying VIRTUALENV_PACKAGE_LOCATION,
		2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
		3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.

~		Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40612446
	~	Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40687629

Commit:

-	13a5c8bf1e1c886f76765cccd8a4e9a5131331ef
+	6004c054ddda236c77792e10fe71578854ff599f

Diff:

Revision 2 (+44 -59)

Show changes

	build-support/set_archflags.sh
	build-support/pants_venv
	build-support/virtualenv
	build-support/bin/ci.sh
	build-support/bin/publish_docs.sh
	build-support/bin/publish_docs_new.sh
	build-support/bin/release.sh

Ship it!

```
LGTM, just some optional nits below
```
build-support/virtualenv (Diff revision 2)
```
${HERE}
```

build-support/virtualenv (Diff revision 2)

I know you didn't change this lilne, but while you're at it...
${HERE}

build-support/virtualenv (Diff revision 2)
```
${HERE}
```

Change Summary:

wrap more env into {}

Commit:

-	6004c054ddda236c77792e10fe71578854ff599f
+	8a16f511bc295916eba03bffca570dda24310eb8

Diff:

Revision 3 (+46 -61)

Show changes

	build-support/set_archflags.sh
	build-support/pants_venv
	build-support/virtualenv
	build-support/bin/ci.sh
	build-support/bin/publish_docs.sh
	build-support/bin/publish_docs_new.sh
	build-support/bin/release.sh

Change Summary:

new travis link https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744

Testing Done:

		manually tested:
		1) not specifying VIRTUALENV_PACKAGE_LOCATION,
		2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
		3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.

~		Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40687629
	~	Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744

Ship it!

```
lgtm!
```

Ship it!

```
Ship It!
```

thanks. can committers take it in?

AR

areitz Nov. 11, 2014, 11:49 p.m.
```
Committed.
```

Description:

~		Create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
~
~		Also the virtual env scripts a bit more robust against curl/tar/activate errors
	~	Create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
	~	Refactor to have a common.sh containing the set_archflags and logging functionalities.
	~	Make the virtual env script a bit more robust against curl/tar/activate errors

You have a pending review.

twitter

Teams

RBCommons

create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download

Testing Done:

Change Summary:

Testing Done:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Testing Done:

Description:

Status: Closed (submitted)