Testing Done: |
|
---|
create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
Review Request #1316 — Created Nov. 11, 2014 and submitted
Information | |
---|---|
jinfeng | |
pants | |
8a16f51... | |
Reviewers | |
pants-reviews | |
areitz, ity, jsirois, zundel |
- Create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
- Refactor to have a common.sh containing the set_archflags and logging functionalities.
- Make the virtual env script a bit more robust against curl/tar/activate errors
manually tested:
1) not specifying VIRTUALENV_PACKAGE_LOCATION,
2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744
-
-
build-support/virtualenv (Diff revision 1) What do you think about factoring these out into a common script, to be shared by this one & the one above?
-
build-support/virtualenv (Diff revision 1) If you build
${VIRTUALENV_URL}=${VIRTUALENV_PACKAGE_LOCATION}/virtualenv-$VIRTUALENV_VERSION.tar.gz
here, it will make the next 4 lines easier to read.
-
-
-
build-support/virtualenv (Diff revision 1) nit: go ahead and surround all variables expanded with { }
Change Summary:
address RB comments and update new travis run link.
Testing Done: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 2 (+44 -59) |
-
LGTM, just some optional nits below
-
-
build-support/virtualenv (Diff revision 2) I know you didn't change this lilne, but while you're at it...
${HERE}
-
Change Summary:
wrap more env into {}
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+46 -61) |
Change Summary:
new travis link https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744
Testing Done: |
|
---|
Description: |
|
---|