create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download

Review Request #1316 — Created Nov. 11, 2014 and submitted

jinfeng
pants
8a16f51...
pants-reviews
areitz, ity, jsirois, zundel
  • Create VIRTUALENV_PACKAGE_LOCATION env var so we can customizae virtualenv package download
  • Refactor to have a common.sh containing the set_archflags and logging functionalities.
  • Make the virtual env script a bit more robust against curl/tar/activate errors

manually tested:
1) not specifying VIRTUALENV_PACKAGE_LOCATION,
2) specifying a valid custom VIRTUALENV_PACKAGE_LOCATION location, and
3) specifying an invalid VIRTUALENV_PACKAGE_LOCATION location.

Travis: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/40690744

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
JI
AR
  1. 
      
  2. build-support/virtualenv (Diff revision 1)
     
     
     
     
     
     
     
     
     

    What do you think about factoring these out into a common script, to be shared by this one & the one above?

  3. build-support/virtualenv (Diff revision 1)
     
     

    If you build ${VIRTUALENV_URL}=${VIRTUALENV_PACKAGE_LOCATION}/virtualenv-$VIRTUALENV_VERSION.tar.gz here, it will make the next 4 lines easier to read.

  4. 
      
ZU
  1. 
      
  2. build-support/virtualenv (Diff revision 1)
     
     

    1>&2 should be removed (its done inside log())

  3. build-support/virtualenv (Diff revision 1)
     
     

    nit: go ahead and surround all variables expanded with { }

  4. 
      
JI
AR
  1. LGTM, just some optional nits below

  2. build-support/virtualenv (Diff revision 2)
     
     

    ${HERE}

  3. build-support/virtualenv (Diff revision 2)
     
     

    I know you didn't change this lilne, but while you're at it...

    ${HERE}

  4. build-support/virtualenv (Diff revision 2)
     
     

    ${HERE}

  5. 
      
JI
JI
IT
  1. lgtm!

  2. 
      
ZU
  1. Ship It!

  2. 
      
JI
  1. thanks. can committers take it in?

  2. 
      
JI
JI
Review request changed

Status: Closed (submitted)

Loading...