what_changed: remove extra sort phase

Review Request #1291 — Created Nov. 6, 2014 and submitted

johanoskarsson
pants
9b1ab4e...
benjyw, jsirois, patricklaw, stuhood

what_changed: the build graph is sorted twice even though the first iteration does not require the targets to be sorted. Removing that sort reduces the call time by about a third in a non scientific test.

ci.sh passes locally

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. Ship It!

  2. 
      
JS
  1. For reference - the RB introducing has no obvious motivation for tsorted in particular: https://rbcommons.com/s/twitter/r/387/diff/1/ - I think it was accidental.

  2. 
      
IT
  1. Ship It!

  2. 
      
PA
  1. Ship It!

  2. 
      
IT
  1. 
      
  2. this comment needs to be updated since the call is now changed.

    1. fixed comment and merged.

  3. 
      
JO
Review request changed

Status: Closed (submitted)

BE
  1. Ship It!

  2. 
      
Loading...