-
-
src/python/pants/backend/jvm/ivy_utils.py (Diff revision 1) I prefer going to @staticmethod when the cls is not needed and there is no intention of over-riding on a subclass.
-
src/python/pants/backend/jvm/tasks/provides.py (Diff revision 1) Odd indent, how about a higher-level break and:
outpath = os.path.join(self.workdir, '{0}.{1}.provides'.format(IvyUtils.identify(targets)[1], conf))
Switch all remaining accesses of 'context.options' to new options.
Review Request #1289 — Created Nov. 6, 2014 and submitted
Information | |
---|---|
benjyw | |
pants | |
1bbbcf8... | |
Reviewers | |
pants-reviews | |
jsirois, patricklaw, zundel |
Killed IvyUtils's dependency on options. It only needed it for
two options that no one is using in practice and this made things
much much simpler.Also made some methods in IvyUtil classmethods, so that call sites
don't need to instantiate it and pass it config.
All task unittests passed.
Full ci running.
-
-
src/python/pants/backend/codegen/tasks/thrift_linter.py (Diff revision 1) I know this isn't a changed line, but it's missing the fact that it can now be set with an ENV variable too, right?
-
-
src/python/pants/backend/jvm/ivy_utils.py (Diff revision 1) I don't use this, but I see how it could be helpful if you are routinely using -SNAPSHOT jars when debugging libraries outside the repo. But I rarely do this and setting the 'mutable' flag on the individual jar() decls has always worked for me.
-
src/python/pants/backend/jvm/tasks/ivy_resolve.py (Diff revision 1) I am pretty sure this is slower than it could be. I think it would be faster to resolve these all at once instead of invoking ivy multiple times inside a loop.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+32 -91) |