Switch all remaining accesses of 'context.options' to new options.

Review Request #1289 — Created Nov. 6, 2014 and submitted

benjyw
pants
1bbbcf8...
pants-reviews
jsirois, patricklaw, zundel

Killed IvyUtils's dependency on options. It only needed it for
two options that no one is using in practice and this made things
much much simpler.

Also made some methods in IvyUtil classmethods, so that call sites
don't need to instantiate it and pass it config.

All task unittests passed.

Full ci running.

JS
  1. 
      
  2. I prefer going to @staticmethod when the cls is not needed and there is no intention of over-riding on a subclass.

    1. Yeah, I think I did that for uniformity with xml_report_path. Changed.

  3. Odd indent, how about a higher-level break and:

          outpath = os.path.join(self.workdir,
                                 '{0}.{1}.provides'.format(IvyUtils.identify(targets)[1], conf))
    
  4. 
      
PA
  1. 
      
  2. I know this isn't a changed line, but it's missing the fact that it can now be set with an ENV variable too, right?

  3. 
      
ZU
  1. 
      
  2. I don't use this, but I see how it could be helpful if you are routinely using -SNAPSHOT jars when debugging libraries outside the repo. But I rarely do this and setting the 'mutable' flag on the individual jar() decls has always worked for me.

    1. Yeah, after talking this over with jsirois, we concluded that the ability to set 'mutable' in the BUILD file is enough.

  3. I am pretty sure this is slower than it could be. I think it would be faster to resolve these all at once instead of invoking ivy multiple times inside a loop.

    1. You may be right, this has been refactored so many times. It's probably worth taking another look at, but Ivy has always been a tricky beast, and sometimes things have to be a certain way for non-obvious reasons (that should be documented but aren't always).

  4. 
      
IT
  1. Ship It!

  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 55b731610a4ce60707cf66df1f55a7205e5dcd80.
Loading...