De-dup sources and report this.

Review Request #128 — Created March 20, 2014 and submitted

jsirois
commons
jsirois/pants/de_dup
260
pants-reviews
benjyw, travis
commit 159688a3aa6621b3f8494b5496aa0791ccc5e0f3
Author: John Sirois <jsirois@twitter.com>
Date:   Thu Mar 20 16:23:35 2014 -0600

    De-dup sources and report this.

 src/python/twitter/pants/tasks/jvm_compile/jvm_compile.py | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
We have internal thrift gymnastics that are leading to dups - this "solves" those issues (jmake blows up when passed the same file 2x) but I'm still digging on why and would prefer to fix out internal thrift issue.  I have not thought through how this might affect all the work jvm_compile.py does.

Looks like:
...
17:00:36 02:34       [java]
                     Invalidated 15 targets containing 919 source files.
17:00:36 02:34         [prepare-analysis]
                     De-duped the following sources:
                     	2 .pants.d/scrooge/java-finagle/com/cloudhopper/phonenumber/thriftjava/Country.java
                     	2 .pants.d/scrooge/java-finagle/com/cloudhopper/phonenumber/thriftjava/CountryCodeSource.java
...
                    	2 .pants.d/scrooge/java-finagle/com/twitter/ibis/thriftjava/YourWeekOnTwitterAdsHighlightType.java
                     	2 .pants.d/scrooge/java-finagle/com/twitter/ibis/thriftjava/YourWeekOnTwitterAdsTopTweetData.java
17:00:37 02:35         [partition-analysis]
                     Compiling a partition containing 770 sources in 15 targets.
17:00:37 02:35         [compile]
17:00:37 02:35           [jmake]
BE
  1. Ship It!
  2. 
      
JS
  1. Thanks - merged
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...