Pin pants support down to python2.7 - dropping 2.6.

Review Request #1278 — Created Nov. 4, 2014 and submitted

jsirois
pants
jsirois/pants/2.7
722, 767
506c445...
pants-reviews
ity, jinfeng, patricklaw, zundel

Testing the python3.3+ waters will happen seperately - this just drops support for running pants against 2.6 as agreed.

3rdparty/python/requirements.txt | 1 -
build-support/bin/ci.sh | 3 +--
build-support/virtualenv | 4 +---
pants | 8 ++++----
pants.ini | 4 ++++
src/python/pants/option/BUILD | 1 -
6 files changed, 10 insertions(+), 11 deletions(-)

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/40117003

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
JS
JS
ZU
  1. Ship It!

  2. 
      
PA
  1. Ship It!

  2. 
      
BE
  1. Ship It!

  2. 
      
AR
  1. Ship It!

  2. 
      
IT
  1. Ship It!

  2. 
      
JI
  1. what about file like

    tests/python/pants_test/python/test_python_run_integration.py
    tests/python/pants_test/python/test_interpreter_selection_integration.py

    1. Those are fine - at least I don't think we've talked as a group about dropping support for pants building 2.6 python_binary targets for users of pants, we've only agreed that the pants binary itself and the pants codebase is dropping support for 2.7.

  2. 
      
JI
  1. Ship It!

  2. 
      
JS
  1. Just a note that I'm working through the odd dep issue hit in travis ci (but not locally).
    I suspect there will be one more RB diff to address this.

  2. 
      
JS
  1. 
      
  2. pants (Diff revision 2)
     
     

    This change and the corresponding one below are incorrect. The virtualenv with fetched deps is active so a bare python was correct.

  3. 
      
JS
JS
JS
JS
  1. CI exceeded 50 minutes and was timed out by trabis - but this happened very close to the end of ITs. I'll re-kick and look at splitting CI into size shards seperately, the 50 minute limit comes up increasingly.

  2. 
      
JS
JS
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/a5ed77e9d69c0200facc8713a2cec7485ede2405

  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...