Refactor artifact cache exceptions.

Review Request #1261 — Created Oct. 31, 2014 and submitted

dturner-tw
pants
89dcfd1...
pants-reviews
benjyw, davidt, ity, johanoskarsson
Presently, the artifact cache will treat any exception during the
insertion process as a non-fatal error.  But some errors should be
fatal -- any sort of misconfiguration, or an attempt to cache
nonexistent files, or an exception thrown while moving files around.
Also remove ArtifactCache.CacheError, as it was not clear when
to use ArtifactCache.CacheError and when to use ArtifactCacheError.


IT
  1. Ship It!

  2. 
      
DA
  1. Linking this on https://rbcommons.com/s/twitter/r/1261/ where Benjy had suggested these changes as follow-ups.

    1. Er, https://rbcommons.com/s/twitter/r/1233/

  2. 
      
BE
  1. Ship It!

  2. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...