allow UTF-8 characters in changelog

Review Request #1228 — Created Oct. 27, 2014 and submitted

dturner-tw
pants
ece3691...
pants-reviews
benjyw, ity, jinfeng, jsirois, patricklaw, peiyu, zundel

Allow UTF-8 characters in changelog

https://travis-ci.org/pantsbuild/pants/builds/39207480

BE
  1. Ship It!

  2. 
      
IT
  1. Ship It!

  2. 
      
DT
  1. Well, weirdly, that Travis build failed in the same way. And it's clearly running the new code because the line number is 808 instead of 807. Hm.

    1. This is the same issue as way back when: print is being used to output unicode, but it's going to a PIPE which has a default encoding output of ascii. The solution is to use sys.stdout.write and manually encode the output when not in the presence of a tty. We should probably write a helper for this.

    2. Oh, duh. What's weird is that sometimes the tests succeed and sometimes they fail. So I guess this patch is good, but we'll need additional patches. I'll merge this and do more at some point

  2. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...