change thrift_linter.py to use new register_options

Review Request #1225 - Created Oct. 27, 2014 and submitted

Information
Joshua Humphries
pants
d446bf5...
Reviewers
pants-reviews
benjyw, zundel

change thrift_linter.py to use new register_options

Take two. Previous change accidentally added "default=False" which was inappropriate and ended up breaking the logic that falls back to a value defined in the BUILD file. Now we explicitly default the flag to None and preserve the desired logic.

I ran the integration tests related to thrift linter, which I inadvertently broke in my last attempt at this:
devpants goal test tests/python/pants_test/tasks:thrift_linter_integration

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Indent should be 2 spaces, not 4. Benjy Weinberger Benjy Weinberger
Eric Ayers
Benjy Weinberger
Eric Ayers
Joshua Humphries
Review request changed

Status: Closed (submitted)

Loading...