move codegen tasks to new options

Review Request #1203 - Created Oct. 24, 2014 and submitted

Information
Joshua Humphries
pants
03e7e58...
Reviewers
pants-reviews
benjyw, zundel

Move codegen tasks to new options

I considered adding integration tests, but for these options, but the expected behavior changes in many cases consist of side effects that are non-trivial to verify (other than thrift-linter).

For "thrift-linter", I ran the "thrift-linter" goal on the various thrift-linter targets in testprojects/. I verified that I could override the "bad-thrift-strict" target using "--no-thrift-linter-strict" and get it to succeed (and vice versa with the "bad-thrift-default" and "bad-thrift-non-strict" targets.

For "gen.scrooge", I ran the "gen" goal on tasks under examples/ and testprojects/. BTW, I could not get any output from the compiler to show up ever. I verified things were working by using the "-ldebug" flag to pants and see that it was indeed adding "--verbose" to the compiler invocation.

For "gen.protoc" and "gen.thrift", I ran the "gen" goal on tasks under testprojects/. I verified that the expected flags were passed to the thrift and proto compilers using the "-ldebug" flag.

Aside: for the "gen.protoc" target, I saw a strange result when indicating "--gen-protoc-lang=python" for a target where Java was actually needed:
Exception message: 'PythonLibrary' object has no attribute 'jar_dependencies'
But this is unrelated to my change and happens with the code on master, too:
$ devpants goal gen testprojects/src/protobuf/com/pants/testproject/proto-ordering:protos --gen-protoc-lang=python

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Joshua Humphries
Joshua Humphries
Eric Ayers
Joshua Humphries
Review request changed

Status: Closed (submitted)

Loading...