jvmdoc_gen: In the event of an exception, call get() on the remaining futures.

Review Request #1202 - Created Oct. 23, 2014 and submitted

Information
David Turner
pants
df9eabd...
Reviewers
pants-reviews
benjyw, ity, jinfeng, jsirois, peiyu, stuhood, zundel

jvmdoc_gen: In the event of an exception, we want to call get() on the remaining futures because otherwise we get errors on exit when multiprocessing tries to kill them because what is dead may never die.

Ideally, we would kill them instead of waiting for them, but I don't see how to do that.

./pants goal test tests/python/pants_test/tasks:jvmdoc_gen

It would be insanely difficult to write a real test for this, because the failure happens in an atexit handler.

John Sirois
David Turner
John Sirois
John Sirois
David Turner
Review request changed

Status: Closed (submitted)

Loading...