Fix problem parsing stuff like options: --compile-java-args='-target 7 -source 7' in pants.rc files

Review Request #1192 — Created Oct. 21, 2014 and submitted

dturner-tw
pants
e88e71f...
pants-reviews
benjyw, ity, jinfeng, jsirois, patricklaw, peiyu

Fix problem parsing stuff like options: --compile-java-args='-target 7 -source 7' in pants.rc files

Ran new tests

BE
  1. 
      
  2. Use textwrap.dedent(), so you can indent this appropriately.

  3. 
      
DT
BE
  1. Ship It!

  2. 
      
JI
  1. Ship It!

  2. 
      
IT
  1. Ship It!

  2. 
      
DT
Review request changed

Status: Closed (submitted)

PE
  1. 
      
  2. src/python/pants/base/rcfile.py (Diff revision 2)
     
     

    interesting now i know why it was like this in pants.new.rc

    --compile-javac-args=-source --compile-javac-args=7 --compile-javac-args=-target --compile-javac-args=7

    that i also tried, doesn't work either with oss pants do you know why?

    1. [compile]
      ---compile-java-args=-source --compile-java-args=7 --compile-java-args=-target --compile-java-args=7

      is what i did, maybe under the wrong section?

    2. See the discussion on the mailing list about sections.

  3. 
      
Loading...