git root calculation for idea goal

Review Request #1189 — Created Oct. 21, 2014 and submitted

fkorotkov
pants
3598287...
pants-reviews
ity

git root calculation for idea goal

tested in dev mode locally. ci passes.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
FK
IT
  1. lgtm

  2. lets add a test for this

    1. yeh. I was thinking about this. I don't have a lot of experience in testing in Python. Is there a way to mock os.listdir? Or how do you think I should test it?

    2. I moved to Git.detect_worktree(). Do we want additional tests for idea goal? We have GitTest with tests for detect_worktree

    3. ping

    4. that works!

  3. 
      
JO
  1. 
      
  2. Could we reuse git.py/scm.py here? Or is this a stop-gap until the plugin is done? Do we expect to remove idea_gen.py completely after that?
    So many questions!

  3. 
      
FK
LA
  1. Ship It!

  2. 
      
DT
  1. Ship It!

  2. 
      
IT
  1. Ship It!

  2. 
      
FK
FK
FK
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/8818ff8ce5b87c5f3b3cd83a63ba4ed79a43dd7f
Loading...