Migrate all JvmTasks to use the new options system.

Review Request #1186 - Created Oct. 21, 2014 and submitted

Information
Benjy Weinberger
pants
e2226aa...
Reviewers
pants-reviews
johanoskarsson, jsirois, zundel

The common --jvm-options, --args, --debug and --confs flags now
live in the base class, but this required migrating all the
relevant tasks at once, hence the scope of this change.

This also gets rid of manual flag-to-config fallback, as the new
options system does this automatically. However this required some
changes to section and key names in pants.ini. I'm documenting
these changes in a spreadsheet, for smooth config migration in
pants install bases.

This required breaking a couple of inconsistently named flags, e.g.,
--benchmark-caliper-args is now just --benchmark-args.

CI passed.

Manually tested that new flags and config settings work.

Issues

  • 1
  • 0
  • 1
  • 2
Description From Last Updated
should this be [run.junit] (I don't see under --help) or [test.junit]? Jin Feng Jin Feng
Ity Kaul
Eric Ayers
Eric Ayers
Eric Ayers
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Jin Feng

   
pants.ini (Diff revision 2)
 
 

benjyw, is this one the default value for jvm_args, or the line you removed was the default value?

jvm_args: ['-Xmx1g', '-XX:MaxPermSize=256m']

if this line is, should the new jvm_options be changed to 2g?

  1. Not sure I understand the question. Can you clarify?

  2. never mind I read it wrong.

Jin Feng

   
pants.ini (Diff revision 2)
 
 

should this be [run.junit] (I don't see under --help) or [test.junit]?

  1. oops, this should be test.junit, good catch.

  2. i'll send a patch.

Benjy Weinberger

   
Loading...