Move workdirs creation from __init__ to pre_execute in jvm_compile & Remove QuietTaskMixin from several tasks

Review Request #1173 - Created Oct. 16, 2014 and submitted

Information
Jin Feng
pants
325
a54a1ad...
Reviewers
pants-reviews
benjyw, ity, jsirois

Move workdirs creation from __init__ to pre_execute in jvm_compile & Remove QuietTaskMixin from several tasks.

  • jvm_compile creates a bunch of dirs in its __init__ method which gets wiped out by clean-all. Instead, move the dirs creation to pre_execute().
  • Another issue is clean-all/clean-all-async/invalidate/ng-killall are with QuietTaskMixin, and once there is one task is QuietTaskMixin, console output will be all suppressed by reporter. This is a fairly common use of combining these goals with others like compile/publish/test/etc.

This is because we only have one reporter for all tasks. A long term solution could be that we have two reporters (or more), one for quiet or one verbose. And tasks can each use its own reporter (not sure if there is any output lineage problem if combined).

Or we can simply make these 3 tasks non quiet. Rest of the ConsoleTask(QuietTaskMixin) derived goals/tasks, their usage is generally standalone. Thus no need for changes.

PANTS_DEV=1 ./pants goal test tests::

Ity Kaul
Benjy Weinberger
John Sirois
Jin Feng
John Sirois
Jin Feng
Review request changed

Status: Closed (submitted)

Loading...