A convenient way to set new-style options in tests.

Review Request #1163 — Created Oct. 14, 2014 and submitted

benjyw
pants
ee85c58...
pants-reviews
jsirois, patricklaw

A convenient way to set new-style options in tests.

CI passed.

Merged this into a branch where I switched a bunch of JvmTask-related tests over to new options, and checked that this worked.

  • 3
  • 0
  • 2
  • 0
  • 5
Description From Last Updated
This is grouped with the wrong imports PA patricklaw
I'm not a fan of this inline or at all, even with explicit parens. I'd prefer to see for_task_types defaulted ... PA patricklaw
Same as above. PA patricklaw
JS
  1. 
      
  2. tests/python/pants_test/base_test.py (Diff revision 1)
     
     

    (new_options or {}).items()

  3. 
      
BE
  1. 
      
  2. tests/python/pants_test/base_test.py (Diff revision 1)
     
     

    Ooops, good catch! I don't yet have any tests that inject their own options this way, that would have exposed this in a hurry...

  3. 
      
BE
JS
  1. Ship It!

  2. 
      
BE
Review request changed

Status: Closed (submitted)

PA
  1. 
      
  2. tests/python/pants_test/base_test.py (Diff revision 2)
     
     

    This is grouped with the wrong imports

  3. tests/python/pants_test/base_test.py (Diff revision 2)
     
     

    I'm not a fan of this inline or at all, even with explicit parens. I'd prefer to see for_task_types defaulted to [] above using the normal for_task_types = for_task_types or [] idiom.

  4. tests/python/pants_test/base_test.py (Diff revision 2)
     
     

    Same as above.

  5. 
      
Loading...