Fix issue 668: make release.sh execute packaged pants without loading internal backends during testing

Review Request #1158 — Created Oct. 14, 2014 and submitted

jinfeng
pants
668
0942231...
pants-reviews
dturner-tw, ity, jsirois, peiyu

The introduction of src/python/internal_backend plugins broke build-support/bin/release.sh.
Release.sh, during dry-run and real testing, fails to execute packaged pants, because it
doesn't have internal_backend packaged within but the repo root pants.ini still asks it
to load them.

The fix is to use PANTS_CONFIG_OVERRIDE during such execution with an empty plugin list.

ran and passed:

  • build-support/bin/release.sh -n
  • build-support/bin/release.sh -t

CI passed: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/37896390

JI
JI
JS
  1. another reviewer will need to patch this in or else I can check back and do so Wednesday am.

  2. build-support/bin/release.sh (Diff revision 1)
     
     

    You could also just check in the alternate pants.ini and comment it instead. Bonus - you stop leaking tmp files.

  3. 
      
JI
IT
  1. lgtm, I will patch this in today.

  2. 
      
JI
Review request changed

Status: Closed (submitted)

Loading...