comments attempting to clear up: what goes in BUILD.tools ? what goes in 3rdparty/BUILD ?
Review Request #1155 - Created Oct. 13, 2014 and submitted
Inspired by conversation on https://rbcommons.com/s/twitter/r/1151/ , I bet we want comments on these files helping folks to figure out which deps go where.
Not sure these particular comments are correct, so "en garde", reviewers.
This is almost true.
protobuf_gen.py has a reference to 3rdparty/BUILD. I put it there by moving a default out of pants.ini. There are other settings in pants.ini that need defaults also point to 3rdparty. I'd like for us either to make these comments a true statement (move protobuf definition to BUILD.tools? what about apps in your repo that need it?), or alter the statement to somehow indicate that some targets have configurable definitions that point to 3rdparty
the conversation around this change made me realize: we're talking about a topic that's already doc'd.
so link to that doc.
(it sounds like the contents of that doc will change when we start doing JVM-tools The Way That We Want To.)
Revision 2 (+6)