Fix scalastyle task, wire it up, make configs optional + refactoring and unit tests

Review Request #1145 - Created Oct. 10, 2014 and submitted

Information
Jin Feng
pants
647
7abfbeb...
Reviewers
pants-reviews
areitz, dturner-tw, jsirois, travis, zundel

Fix scalastyle task, wire it up, make configs optional + refactoring and unit tests

  • fix the task, which has slipped out of maintenance.
  • wire it up in OS pants.
  • but make it flexible so that pants_internal or other private wrapper of OS pants won't fail if they don't have scalastyle config and excludes present (making config/exclude optional)
  • some refactoring so I can write unit tests easily.
  • unit tests and end to end tests
  • CI passed: https://travis-ci.org/jinfeng/jinfeng-pants-fork/builds/37824308

    • PANTS_DEV=1 ./pants goal test tests::
  • positive manual test:

$ PANTS_DEV=1 ./pants goal compile examples/src/scala/com/pants/example/hello/welcome
...
...
...
16:00:13 00:02 [compile]
16:00:13 00:02 [jvm]
...
...
16:00:22 00:11 [scalastyle]
16:00:22 00:11 [bootstrap-scalastyle]
16:00:23 00:12 [org.scalastyle.Main]
Waiting for background workers to finish.
SUCCESS

  • negative manual test (with the examples/src/scala/com/pants/example/Welcome.scala to break the ImportGroupingChecker rule:

$ PANTS_DEV=1 ./pants goal compile examples/src/scala/com/pants/example/hello/welcome
...
...
...
16:03:42 00:00 [compile]
16:03:42 00:00 [jvm]
...
...
16:03:44 00:02 [scalastyle]
16:03:44 00:02 [org.scalastyle.Main]
==== stderr ====

                 ==== stdout ====
                 error file=/Users/jinfeng/workspace/github-pants-jinfeng/examples/src/scala/com/pants/example/hello/welcome/Welcome.scala message=Imports should be grouped together  line=13 column=0
                 Processed 1 file(s)
                 Found 1 errors
                 Found 0 warnings
                 Finished in 56 ms

FAILURE: java org.scalastyle.Main ... exited non-zero (1)

           Waiting for background workers to finish.
           FAILURE
Eric Ayers
David Turner
Jin Feng
David Turner
Jin Feng
David Turner
David Turner
Jin Feng
Jin Feng
John Sirois
Jin Feng
Jin Feng
John Sirois
John Sirois
Jin Feng
John Sirois
John Sirois
Jin Feng
Review request changed

Status: Closed (submitted)

Loading...