Remove hack to add java_sources in context

Review Request #1130 - Created Oct. 8, 2014 and submitted

Information
Tejal Desai
pants
543293c...
Reviewers
pants-reviews
ity, jsirois, patricklaw, zundel

Remove hack to add java_sources in context

Yes:
https://travis-ci.org/pantsbuild/pants/builds/37349364

Maunally generated idea for
./pants goal idea testprojects/src/scala/com/pants/testproject/javasources:javasources and
./pants goal idea testprojects/src/scala/com/pants/testproject/javasources:javasources --idea-intransitive

Both have dependent java_sources targets configured in generated Project Structure.

With Eric's hack to add java_sources in ide_gen for scala_library, we no longer need the java_sources to be added to the self.context targets.
https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/ide_gen.py#L552

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
I believe this makes Target.closure() completely unused--so you can nuke it in Target, too. Patrick Lawson Patrick Lawson
Tejal Desai
Eric Ayers
Patrick Lawson
John Sirois
Tejal Desai
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks folks!
Loading...