Make sure that 'option java_package' always overrides 'package' in protobuf_gen

Review Request #1108 - Created Oct. 2, 2014 and submitted

Information
Eric Ayers
pants
zundel/protobuf-java-package-precedence
629
95c13af...
Reviewers
pants-reviews
ity

Found a bug where:

option java_package = "foo";
package bar;

was processed differently from

package bar;
option java_package = "foo";

For java code generation, the setting of 'option java_package' should always win.

Added a unit test.

Ity Kaul
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review!
commit 1bdfef0
Loading...