Better handling of common source roots for modules

Review Request #1103 — Created Oct. 1, 2014 and submitted

fkorotkov
intellij-pants-plugin
53080a6...
tejal

Better handling of common source roots for modules

manually

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
for (String targetName : projectInfo.targets.keys()) should suffice - you are not actually using the value in the loop afaics IT ity
TE
  1. Can you describe what will be the new common source roots look like??

    1. It will be a separate module with dependecies and librariers created as a union of dependencies and libraries of all targets that this root is part of.

      Dependencies and libraries won't be exported that's why it won't polute classpaths of the original modules.

    2. ah ok .

      Thanks

  2. 
      
TE
  1. 
      
  2. So this is the new module you are adding.

  3. Adding all the deps and source roots to this new module

  4. Adding this new module as a dependency.

  5. 
      
TE
  1. I think this looks good.

    We need to add tests ASAP

    1. That's true! I'll investigate it on Sunday.

    2. BTW I remember you had a fix for circular dependencies. Have you merged it?

    3. no. when are you going to merge this to master?

    4. already merged. we can add you fix pretty quick.

    5. ok.. can you look at the comments for https://rbcommons.com/s/twitter/r/1047/ ?

      I think i want to see how this change works without --no-single-module-per-codegen.

      If we can get rid of OOM's then i am thinking of reverting the flag

  2. 
      
IT
  1. run checkstyle on these classes - there are lines >100 chars etc. throughout

  2. for (String targetName : projectInfo.targets.keys())

    should suffice - you are not actually using the value in the loop afaics

  3. 
      
FK
Review request changed

Status: Closed (submitted)

Loading...