Fix cross-device symlinking bug.

Review Request #110 — Created March 15, 2014 and submitted

benjyw
commons
pants-reviews
wickman
Fix cross-device symlinking bug.


WI
  1. 
      
  2. can you add a TODO to make this atomic?  i can get to that sometime next week.
    
    rationale: if shutil.move detects a cross-device link, it will resort to copytree.  but if we get a cross-device link, we'll want to copy to dest+uuid4, then os.rename(dest+uuid4, dest) in order that the target cache is not in a corrupt state during the copy.
  3. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...