Protobuf and payload cleanups

Review Request #1099 — Created Oct. 2, 2014 and submitted

zundel
pants
zundel/protobuf-examples-and-payload-cleanups
623
c5ac282...
pants-reviews
ity, patricklaw

Moved some of the protobuf examples around to be more consistent.
Some cleanups from payload refactoring
Added a deprecation message for the unused 'buildflags' attribute in java_protobuf_library
Removed the ability to use a jar_dependency in java_protobuf_library imports.

CI is green.
Added a unit test for the java_protobuf_library target

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
PA
  1. 
      
  2. You can just use GenericField for this now.

  3. s/buildfiles/buildflags. I'd also say "sets" rather than "references"

  4. now self.payload.raw_imports == self._library_imports, so this whole thing can be simplified

  5. 
      
ZU
ZU
  1. 
      
  2. tests/python/pants_test/tasks/BUILD (Diff revision 2)
     
     

    This is unrelated, but tests mysteriously started to fail on me.

  3. 
      
PA
  1. 
      
  2. Prefer six compatibility types over t.c.lang in new code: https://pythonhosted.org/six/

    Here you could use six.string_types, or be extra extra careful and only allow unicode (six.text_type)

  3. 
      
PA
  1. Ship It!

  2. 
      
ZU
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

commit 0ea28ad
Loading...