Switch a handful of flags over to the new registration style.

Review Request #1097 — Created Oct. 1, 2014 and submitted

benjyw
pants
fefbd4d...
pants-reviews
jsirois, patricklaw, zundel

This includes a superclass-subclass scenario (ConsoleTask-ListGoals)
and a GroupTask scenario (JvmCompile).

Note that the code that reads and uses the flags needn't change yet.
The legacy flags layer places the values in the existing destinations.

Note: Relies on https://rbcommons.com/s/twitter/r/1096/.

Once this is in I will write up a quick guide to porting flags,
and then we can set ourselves loose on them!

Ran all tests. Manually ran the relevant pants goals with various flag settings.

PA
  1. Ship It!

  2. 
      
ZU
  1. 
      
  2. no super() invocation here? It may not be necessary, but it might help prevent future cut-and-paste errors.

    1. Yeah, probably a good idea. Added.

  3. 
      
JS
  1. Ship It!

  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Loading...