Hook new-style registration up to the goal runner.

Review Request #1096 — Created Oct. 1, 2014 and submitted

benjyw
pants
deb96e3...
pants-reviews
jsirois, patricklaw, zundel

Hook new-style registration up to the goal runner.

Provides appropriate special-casing for GroupTask.

Note: relies on https://rbcommons.com/s/twitter/r/1095/.

Ran all tests. Manually tested new-style registration on top of this.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
LA
  1. 
      
  2. trying this out, I think your BUILD file wants a dep on this

    1. Good catch! But note that this isn't ready to try out yet. It's not going to be pushed independently.

    2. isn't ready to try out yet

      OK. I gave this a whirl along with 1095 and 1097 and tried generating our reflection-y docs.

      As it is, the equivalent of http://pantsbuild.github.io/goals_reference.html#gref-goal-goals
      shows no options for goal goals and says "Implemented by abc.goals_ListGoals"
      If that's already on your radar, then never mind.

  3. 
      
PA
  1. 
      
  2. I tend to be paranoid about calling os.environ.copy() if I'm passing it around, since I don't want someone downstream to modify it.

  3. 
      
ZU
  1. 
      
  2. the names of ...

  3. Can you document this parameter? you used it in test_group_task.py

  4. I looked hard for a problem with this and couldn't find one. It might make another patch I have up for review simpler.

    1. Yeah, I'm not sure why it was the way it was.

  5. 
      
JS
  1. 
      
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...