Allow a task type know its own options scope.

Review Request #1095 — Created Sept. 30, 2014 and submitted

benjyw
pants
c4affe2...
pants-reviews
jsirois, patricklaw, zundel

E.g., JavaCompile should know that its options are under compile.java.

Also fix some stale comments from the goal->task terminology change.

Ran all the tests. Tested that this works when registering options in the new style (will be sent for review in a future change).

BE
BE
PA
  1. Ship It!

  2. 
      
ZU
  1. 
      
  2. src/python/pants/goal/goal.py (Diff revision 2)
     
     

    I don't know if this is a mistake, but it is confusing to read. You listed the arguments in a different order than using them in the format string. If you do that, maybe you should name them instead of using numeric values in the format string.

    1. Oh, nice catch. That was just a dumb mistake. Fixed. The name doesn't really matter anyway, I just tried to make it useful for debugging.

  3. 
      
JS
  1. 
      
  2. src/python/pants/goal/goal.py (Diff revision 2)
     
     

    s/{ 'options_scope'/{'options_scope'/

  3. src/python/pants/goal/goal.py (Diff revision 2)
     
     

    This and TaskBase.known_scopes are unused and un-doc'd in this RB - kill.

    1. This is used in a subsequent change. Added docs though.

  4. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...