Fix order-dependent force handling: if a version is forced in one place, it is forced everywhere. Two JarLibraries might compare equal even though their force setting is different; we want force to be dominant.

Review Request #1085 — Created Sept. 29, 2014 and submitted

dturner-tw
pants
10aa0a0...
pants-reviews
jsirois, stuhood
Fix order-dependent force handling: if a version is forced in one place, it is forced everywhere.  Two JarLibraries might compare equal even though their force setting is different; we want force to be dominant.


JS
  1. This makes sense, but it would be a perfect time to add a unit test for this logic.

  2. 
      
DT
JS
  1. Thanks David!

  2. 
      
JS
  1. In master @ https://github.com/pantsbuild/pants/commit/d90bdc0d4046a7d1b3d0c7b243ebc31de19bd9fb
    Please mark this review as submitted.

  2. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...